<html>
<head><meta charset="utf-8"><title>Summarize diffs · t-compiler/wg-self-profile · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/index.html">t-compiler/wg-self-profile</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html">Summarize diffs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="164257726"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164257726" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164257726">(Apr 26 2019 at 12:41)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span>  has written up <a href="https://github.com/rust-lang/measureme/issues/33" target="_blank" title="https://github.com/rust-lang/measureme/issues/33">an issue</a> for diff output from the summarize tool. I've <a href="https://github.com/rust-lang/measureme/issues/33#issuecomment-487042031" target="_blank" title="https://github.com/rust-lang/measureme/issues/33#issuecomment-487042031">added</a> some getting started instructions if anyone is interested in working on this. I'm happy to answer questions or provide help to anyone interested.</p>
<p>Otherwise, I'll probably work on this sometime in the next week or two.</p>



<a name="164257923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164257923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164257923">(Apr 26 2019 at 12:44)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> </p>
<blockquote>
<p>We'll need to change the usize fields to be signed. i64 is probably appropriate.</p>
</blockquote>
<p>Can't you use <code>impl Sub for QueryData</code> with <code>type Output = QueryDiff;</code> where you use <code>i64</code> in the <code>QueryDiff</code>?</p>



<a name="164261124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261124">(Apr 26 2019 at 13:27)</a>:</h4>
<p>Seems unfortunate to have two identical data structures that differ only by the numerical types of a few fields</p>



<a name="164261148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261148">(Apr 26 2019 at 13:27)</a>:</h4>
<p>I think perf.rlo will also be interested in this feature and they'd probably rather not duplicate the data structures on their side either</p>



<a name="164261531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261531">(Apr 26 2019 at 13:32)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span>  there's always <code>pub struct QueryData&lt;N = usize&gt; {</code> :P</p>



<a name="164261546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261546">(Apr 26 2019 at 13:32)</a>:</h4>
<p>is that const generics?</p>



<a name="164261563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261563">(Apr 26 2019 at 13:33)</a>:</h4>
<p>Or whatever we're calling it these days lol</p>



<a name="164261574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261574">(Apr 26 2019 at 13:33)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span>  no it's just a type parameter with a default set to <code>usize</code></p>



<a name="164261585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261585">(Apr 26 2019 at 13:33)</a>:</h4>
<p>Oh right</p>



<a name="164261597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261597">(Apr 26 2019 at 13:33)</a>:</h4>
<p>I read <code>N: usize</code></p>



<a name="164261606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164261606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164261606">(Apr 26 2019 at 13:33)</a>:</h4>
<p>Should probably go have that morning cup of coffee</p>



<a name="164262459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164262459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alice Ryhl <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164262459">(Apr 26 2019 at 13:43)</a>:</h4>
<p>I mean isn't a QueryDiff fundamentally different from a QueryData in a semantic way? I would default to two types</p>



<a name="164262734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164262734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alice Ryhl <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164262734">(Apr 26 2019 at 13:46)</a>:</h4>
<p>And wouldn't the diff need to keep track of lines only in one of the datasets too in an additional field</p>



<a name="164263052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164263052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164263052">(Apr 26 2019 at 13:50)</a>:</h4>
<p>I think naively, any non matching lines would be shown as <code>+\-</code> their full value</p>



<a name="164298124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164298124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alice Ryhl <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164298124">(Apr 26 2019 at 21:09)</a>:</h4>
<p>Thinking a bit more about it, I think we need to remember both the old and new value (or ratio I guess), since otherwise we can't detect if, say, +100 cache hits is a 0.1% increase or a 100% increase.</p>



<a name="164299253"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187831-t-compiler/wg-self-profile/topic/Summarize%20diffs/near/164299253" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/187831-t-compiler/wg-self-profile/topic/Summarize.20diffs.html#164299253">(Apr 26 2019 at 21:27)</a>:</h4>
<p>Yeah, that seems like a reasonable concern. We should test out it though. It may be too much noise to show the ratio for every value (or at all) and the user could always run a regular summarization of the data sets to see the actual values.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>